JSON codec wrapper to handle exceptions #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
json-guards
branch
from
c4e4fff to
42f0af8
Compare
kattrali
reviewed
Sep 4, 2020
NSJSONSerialization can sometimes throw an exception, even though the API has an NSError field. BSGJSONSerialization wraps all NSJSONSerialization calls in a try/catch block, turning any resulting exceptions into an NSError. This gives us a more robust way to handle JSON in a unified manner, as opposed to having to remember to put try/catch around every (de)serialization, or check all dictionaries manually for valid data.
kstenerud
force-pushed
the
json-guards
branch
from
42f0af8 to
df51d7d
Compare
kattrali
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
NSJSONSerialization can sometimes throw an exception, even though the API has an NSError field. We should have a unified way to handle JSON without having to remember to put in try/catch blocks, or manually go through our data to ensure it conforms before attempting to encode, or worry about bad data causing the decoder to freak out.
Design
BSGJSONSerialization wraps all NSJSONSerialization calls in a try/catch block, turning any resulting exceptions into an NSError.
Changeset
Testing