[PLAT-4707] Record thread information for unhandled JS errors #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
rn-thread-unhandled
branch
from
f13a538 to
61ba11f
Compare
fractalwrench
force-pushed
the
rn-thread-unhandled
branch
from
61ba11f to
55cf299
Compare
Bugsnag/KSCrash/Source/KSCrash/Recording/Sentry/BSG_KSCrashSentry.h
Outdated
Show resolved
Hide resolved
|
Addressed review feedback |
tomlongridge
approved these changes
Jul 30, 2020
tomlongridge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Records thread information for unhandled JS errors. The thread information was not captured for unhandled JS errors when
BSGThreadSendPolicyUnhandledOnlywas set because the native layer used the presence ofBSG_KSCrashTypeUserReportedas thecrashTypeto determine whether an error was unhandled instead.This change alters the
captureThreadTracemethod to calculate whether threads should be captured or not, and setsthreadTracingEnabledappropriately. By default this value is set when installing KSCrash - for handled errors this value is overwritten.Additionally the crash context has been set to a local struct, which avoids the scenario where multiple notify calls overwrite a global struct.
Note: sending a handled error will overwrite the crash context currently which means the thread send behaviour is incorrect for unhandled errors sent after handled errors. This will be addressed in a separate PR which avoids reusing the crash context.
Tests
Covered by existing E2E test coverage, additionally verified in an Objective C example app against handled + unhandled errors.
References