Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved binary images store declaration from header file #725

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Moved binary images store declaration from header file #725

merged 2 commits into from
Jun 29, 2020

Conversation

tomlongridge
Copy link
Contributor

@tomlongridge tomlongridge commented Jun 26, 2020 •
edited
Loading

Goal

The bsg_mach_binary_images static variable is currently declared in a header which is potentially causing bugsnag/bugsnag-react-native#462:

Definition of '' must be imported from module 'BugsnagReactNative.BSG_KSMachHeaders' before it is required

Design

Declaring it in the header potentially creates multiple instances of the variable so is not good practice.

Tests

  • Ensured unhandled errors are symbolicating correctly.
  • Ran against deadlock repro case to ensure no regression.

@tomlongridge tomlongridge marked this pull request as ready for review June 26, 2020 17:54
@tomlongridge tomlongridge merged commit de1428c into master Jun 29, 2020
@tomlongridge tomlongridge deleted the tom/move-mach-header-data branch June 29, 2020 09:05
@tomlongridge tomlongridge mentioned this pull request Jun 29, 2020
Merged
tomlongridge added a commit that referenced this pull request Jul 10, 2020
@tomlongridge
Correction to changelog (#725->727)
4491154 
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractalwrench fractalwrench fractalwrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomlongridge @fractalwrench