Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stacktrace properties for error/thread readwrite #722

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Make stacktrace properties for error/thread readwrite #722

merged 2 commits into from
Jun 26, 2020

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Jun 26, 2020 •
edited
Loading

Goal

Makes the stacktrace property on errors.stacktrace mutable, to allow users to modify the stacktrace.

Tests

Added a unit test to verify the stacktrace is mutable.

@fractalwrench fractalwrench force-pushed the make-error-stacktrace-readwrite branch from d04577b to 04f68a0 Compare June 26, 2020 09:58
@fractalwrench fractalwrench marked this pull request as ready for review June 26, 2020 09:59
@fractalwrench fractalwrench changed the title Make error.stacktrace property readwrite Make stacktrace properties for error/thread readwrite Jun 26, 2020
@fractalwrench fractalwrench force-pushed the make-error-stacktrace-readwrite branch from 04f68a0 to 522c4de Compare June 26, 2020 11:05
tomlongridge
tomlongridge approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@tomlongridge tomlongridge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ran a callback in examples and worked as expected.

@tomlongridge tomlongridge merged commit 0f7b814 into master Jun 26, 2020
@tomlongridge tomlongridge deleted the make-error-stacktrace-readwrite branch June 26, 2020 16:43
@xljones xljones mentioned this pull request Sep 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @tomlongridge