fix(recording): corrected string comparison of thread name #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
approved these changes
Jun 26, 2020
…arison-mach-exceptions
tomlongridge
force-pushed
the
tom/fix-string-comparison-mach-exceptions
branch
from
8642f2b to
1d40a38
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes incorrect string comparison in mach exception handling. There doesn't seem to be a functional problem with the existing implementation (presumably the same char sequence is used in memory through compiler optimization), but this PR makes it certain and avoids new static compile error in Xcode 12.
Changeset
BSG_KSCrashSentry_MachException.c- amended string comparison to usestrcmprather than equality.BSG_KSCrash.m- adding missing "@" to DEBUG log call.Tests
Verified through log messages that secondary thread is getting suspended as intended.