Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): remove client operations for adding/removing callbacks #713

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

tomlongridge
Copy link
Contributor

Goal

Decision made that modifying delivery-time callbacks on the client doesn't seem very useful (as it's on the subsequent launch) and likely to cause confusion, so removing them from the API.

Changeset

  • Removed from code and headers
  • Removed tests for the methods specifically
  • Updated expectations on e2e tests

@twometresteve
Copy link
Contributor

Nit: The changelog entry includes the following. Technically true, but potentially confusing (suggest removing "Bugsnag and")

* Added `addOnSendBlock:`, `removeOnSendBlock:` and `clearOnSendBlocks` methods to `Bugsnag` 
  and `BugsnagConfiguration`.
  [#485](https://github.com/bugsnag/bugsnag-cocoa/pull/485)

@tomlongridge tomlongridge merged commit 212ae6c into v6 Jun 19, 2020
@tomlongridge tomlongridge deleted the v6-remove-client-callback-operations branch June 19, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants