Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change user persistence to use NSUserDefaults #590

Merged
merged 4 commits into from
May 19, 2020

Conversation

robinmacharg
Copy link
Contributor

Goal

See #469. This change converts that work to use NSUserDefaults instead of keychain access. It also de-vendors SSKeychain, and reinstates some tests that are now valid.

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
    • Release
  • The correct target branch has been selected (master for fixes, next for
    features)
  • If this is intended for release have all of the pre-release checks been considered?
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg force-pushed the v6-change-user-persistence-tonsuserdefaults branch from 2dd0ede to 74dfeef Compare May 12, 2020 18:48
@robinmacharg robinmacharg marked this pull request as ready for review May 12, 2020 18:49
@robinmacharg robinmacharg merged commit 12a94ed into v6 May 19, 2020
@robinmacharg robinmacharg deleted the v6-change-user-persistence-tonsuserdefaults branch May 19, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants