Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BugsnagOnErrorBlock return BOOL rather than void #555

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Updates BugsnagOnErrorBlock to return BOOL rather than void. This gives consistency with the other callbacks and allows the event to be discarded if the user does not want to report it.

Copy link
Contributor

@robinmacharg robinmacharg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@fractalwrench fractalwrench merged commit 0781176 into v6 Apr 22, 2020
@fractalwrench fractalwrench deleted the v6-on-error branch April 22, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants