Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Added Configuration <NSCopying> #524

Merged
merged 4 commits into from
Apr 3, 2020

Conversation

robinmacharg
Copy link
Contributor

Goal

Copy the passed BugsnagConfiguration object on BugsnagClient initialisation. This helps reduce unexpected mutation of a Client's configuration.

Design

Implemented <NSCopying> on BugsnagConfiguration, producing a shallow copy of itself. Updated config-dependent code to take copies appropriately.

Changeset

BugsnagConfiguration primarily with BugsnagClient making use of these.

Tests

Basic testing that copied configuration's properties don't mutate unexpectedly. Adjusted some existing tests that made assumptions based on the mutability of a passed-in config.

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg force-pushed the robin/Add-deep-copying-of-the-Configuration-object branch from 356d545 to 83d85b1 Compare April 3, 2020 07:48
@robinmacharg robinmacharg marked this pull request as ready for review April 3, 2020 09:03
Tests/BugsnagConfigurationTests.m Outdated Show resolved Hide resolved
@robinmacharg robinmacharg merged commit 6f7fcd9 into v6 Apr 3, 2020
@robinmacharg robinmacharg deleted the robin/Add-deep-copying-of-the-Configuration-object branch April 3, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants