Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that config.maxBreadcrumbs must be between 0-100 #511

Merged
merged 3 commits into from
Mar 31, 2020

Conversation

fractalwrench
Copy link
Contributor

Goal

Enforces that the maximum number of breadcrumbs should be between 0-100.

Changeset

Updated setter to ignore and log an error if a number outside the given range is entered.

Tests

Added a unit test to verify the behaviour.

@fractalwrench fractalwrench force-pushed the v6-max-crumb-validation branch from 019951a to 15b7939 Compare March 30, 2020 11:19
@fractalwrench fractalwrench merged commit 2bef3ef into v6 Mar 31, 2020
@fractalwrench fractalwrench deleted the v6-max-crumb-validation branch March 31, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants