Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leaveBreadcrumbWithBlock from public api #491

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

fractalwrench
Copy link
Contributor

Removes the leaveBreadcrumbWithBlock method from our public API. This is still accessible internally as the implementation for adding breadcrumbs currently relies on this method.

@tomlongridge
Copy link
Contributor

Looks like a MR compile issue: https://travis-ci.com/github/bugsnag/bugsnag-cocoa/jobs/299882365#L814

@fractalwrench fractalwrench force-pushed the v6-leave-breadcrumb-block branch from df1da63 to cac1d11 Compare March 19, 2020 15:22
@fractalwrench
Copy link
Contributor Author

Amended the scenarios - the leaveBreadcrumbWithBlock method is converted to another method name in Swift which was not updated. I've verified that the breadcrumb scenario passes locally.

@fractalwrench fractalwrench merged commit 70492ce into v6 Mar 20, 2020
@fractalwrench fractalwrench deleted the v6-leave-breadcrumb-block branch March 20, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants