(feat) Enhanced orientation breadcrumbs with explicit "from" and "to"

[robinmacharg]

Goal

Report both the old and new orientation values as metadata. Match the casing for the breadcrumb message.

Design

On device orientation change notification, record the current device orientation to be used the next time orientation changes. When both current and previous orientations are non-nil and differ record an appropriate breadcrumb.

Changeset

The change is located in BugsnagClient.

Tests

This is difficult to test. For Unit testing mocking would allow the UIDevice to be stubbed out and simulate a rotation. For CI/e2e tests the possibility exists (but has not been proven to work) of sending a rotation keypress (Cmd-Left) to the simulator.

The implementation is simple and in the interests of time this feature is left as a manual test until mocking libraries have been added.

Review

Outstanding Questions

• This pull request is ready for:
  • Initial review of the intended approach, not yet feature complete
  • Structural review of the classes, functions, and properties modified
  • Final review

• The correct target branch has been selected (master for fixes, next for
  features)
• Consistency across platforms for structures or concepts added or modified
• Consistency between the changeset and the goal stated above
• Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
• Usage friction - is the proposed change in usage cumbersome or complicated?
• Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
• Concurrency concerns - if components are accessed asynchronously, what issues will arise
• Thoroughness of added tests and any missing edge cases
• Idiomatic use of the language

[fractalwrench]

A few minor comments, otherwise this looks like a good implementation 👍

[fractalwrench]

LGTM ✅