Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration.removeOnSession() #483

Merged
merged 10 commits into from
Mar 12, 2020

Conversation

robinmacharg
Copy link
Contributor

@robinmacharg robinmacharg commented Mar 11, 2020

Goal

To add the {add,remove}OnSession() methods to Bugsnag and BugsnagConfiguration to bring it in line with other notifiers.

Design

Simple. The relevant property is an ObjC array; all necessary checks are performed by the type system and array implementation. Testing ensures that the method performs as expected.

Changeset

Two methods added to Bugsnag and BugsnagConfiguration and tests.

Tests

Quite comprehensive testing of both addition and removal of blocks.

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg force-pushed the robin/add-Configuration.removeOnSession branch from bbe0109 to 396f7cf Compare March 11, 2020 10:23
@robinmacharg robinmacharg changed the base branch from master to v6 March 11, 2020 10:24
@robinmacharg robinmacharg marked this pull request as ready for review March 11, 2020 11:18
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comprehensive tests! Left a few comments inline - in particular I think it'd be good to determine how to make a deep-copy of BugsnagConfiguration sooner rather than later.

Source/Bugsnag.h Outdated Show resolved Hide resolved
Source/Bugsnag.m Show resolved Hide resolved
Source/BugsnagConfiguration.m Show resolved Hide resolved
Tests/BugsnagConfigurationTests.m Show resolved Hide resolved
@robinmacharg robinmacharg self-assigned this Mar 11, 2020
@robinmacharg robinmacharg merged commit d723cd8 into v6 Mar 12, 2020
@robinmacharg robinmacharg deleted the robin/add-Configuration.removeOnSession branch March 12, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants