-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration.removeOnSession() #483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmacharg
force-pushed
the
robin/add-Configuration.removeOnSession
branch
from
March 11, 2020 10:23
bbe0109
to
396f7cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice comprehensive tests! Left a few comments inline - in particular I think it'd be good to determine how to make a deep-copy of BugsnagConfiguration
sooner rather than later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To add the
{add,remove}OnSession()
methods toBugsnag
andBugsnagConfiguration
to bring it in line with other notifiers.Design
Simple. The relevant property is an ObjC array; all necessary checks are performed by the type system and array implementation. Testing ensures that the method performs as expected.
Changeset
Two methods added to
Bugsnag
andBugsnagConfiguration
and tests.Tests
Quite comprehensive testing of both addition and removal of blocks.
Review
Outstanding Questions
master
for fixes,next
forfeatures)