-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Implement configurable enabledErrorTypes #477
Merged
robinmacharg
merged 18 commits into
spec-compliance
from
robinmacharg/Move-Configuration.reportOOMs-into-Configuration.enabledErrorTypes-option
Mar 5, 2020
Merged
(feat) Implement configurable enabledErrorTypes #477
robinmacharg
merged 18 commits into
spec-compliance
from
robinmacharg/Move-Configuration.reportOOMs-into-Configuration.enabledErrorTypes-option
Mar 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmacharg
force-pushed
the
robinmacharg/Move-Configuration.reportOOMs-into-Configuration.enabledErrorTypes-option
branch
from
February 28, 2020 14:22
43fc0a6
to
b16b9c8
Compare
Note to self: I need to check e2e on Mac vs iOS. |
kattrali
suggested changes
Feb 28, 2020
…ration.enabledErrorTypes-option' of github.com:bugsnag/bugsnag-cocoa into robinmacharg/Move-Configuration.reportOOMs-into-Configuration.enabledErrorTypes-option
robinmacharg
force-pushed
the
robinmacharg/Move-Configuration.reportOOMs-into-Configuration.enabledErrorTypes-option
branch
from
March 2, 2020 11:23
b16585c
to
d5838c0
Compare
robinmacharg
force-pushed
the
robinmacharg/Move-Configuration.reportOOMs-into-Configuration.enabledErrorTypes-option
branch
from
March 2, 2020 13:48
d5838c0
to
9d1cf03
Compare
…guration.reportOOMs-into-Configuration.enabledErrorTypes-option
…guration.reportOOMs-into-Configuration.enabledErrorTypes-option
…ed block assignment)
…guration.reportOOMs-into-Configuration.enabledErrorTypes-option
fractalwrench
deleted the
robinmacharg/Move-Configuration.reportOOMs-into-Configuration.enabledErrorTypes-option
branch
May 13, 2020 13:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To allow users to configure the types of event that are reported.
Design
This is implemented as a bitfield on
BugsnagConfiguration
.BugsnagSentry
translates this to equivalent KSCrash values. The OOM value is examined inBugsnagNotifier
. The bitfield mapping has been broken out to make it testable.Changeset
As above,
BugsnagConfiguration
,BugsnagSentry
andBugsnagNotifier
.Tests
This is difficult to test at unit-level. What can be has been. E2E tests better test the behaviour and this is where the effort has been concentrated.
Review
Outstanding Questions
master
for fixes,next
forfeatures)