refactor: Filter breadcrumbs through type selection #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmacharg
reviewed
Mar 2, 2020
Comment on lines
+19
to
+20
| breadcrumbs from being captured. | ||
|
|
There was a problem hiding this comment.
Suggested change
| breadcrumbs from being captured. | |
| breadcrumbs from being captured. | |
| [#476](https://github.com/bugsnag/bugsnag-cocoa/pull/476) |
robinmacharg
approved these changes
Mar 2, 2020
# Conflicts: # Source/BugsnagConfiguration.m # Tests/BugsnagBreadcrumbsTest.m # UPGRADING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allow filtering which breadcrumbs are captured using the breadcrumb
typefieldDesign
enabledBreadcrumbTypes. Types can be turned off or on by modifying this property.Subsequent calls to
leaveBreadcrumbare then ignored or create breadcrumbs based on the type.Tests
Bugsnag.leaveBreadcrumb()