feat: Add metadata accessors to BugsnagEvent #465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a BaseUnitTest to collect common setup patterns.
Goal
Add metadata accessor methods to BugsnagEvent, to align it with other metadata-utilising classes.
Design
Implement the necessary methods (add*, clear* and get*), add tests. These methods deal with
NSDictionary
s, not BugsnagMetadataChangeset
Changes primarily to
BugsnagEvent
.Tests
Added tests that the new methods performed as expected.
Also created a top-level Unit Test base class for common setup tasks. There's a question over whether it would be clearer to have a helper class with static methods.
Review
Outstanding Questions
See above.
master
for fixes,next
forfeatures)