Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get metadata section key #463

Merged

Conversation

robinmacharg
Copy link
Contributor

Goal

Add Bugsnag.getMetadata(_ section, key) to better align with other notifiers.

Design

The functionality was actually added in a previous PR. This PR tidies that up slightly. To allow for keys with spaces more discrete dictionary access was used. Tests were added.

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg changed the title Robinmacharg/add get metadata section key Add get metadata section key Feb 13, 2020
@robinmacharg robinmacharg marked this pull request as ready for review February 13, 2020 09:45
The functionality was actually added in commit f4b69a9.  This commit tidies it up slightly.

Added PR
@robinmacharg robinmacharg force-pushed the robinmacharg/add-get-metadata-section-key branch from 5002443 to 7d54ea4 Compare February 13, 2020 10:19
@robinmacharg robinmacharg changed the base branch from master to spec-compliance February 14, 2020 09:15
@robinmacharg robinmacharg merged commit f6a342a into spec-compliance Feb 18, 2020
@robinmacharg robinmacharg deleted the robinmacharg/add-get-metadata-section-key branch February 18, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants