Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bugsnag.clearMetadata() #462

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

robinmacharg
Copy link
Contributor

Goal

To implement Bugsnag.clearMetadata() variants.

Design

This has been implemented for both section and key variants in the top-level Bugsnag class as well as the backing BugsnagMetadata class. Deviates mildly from the spec. in method message naming. Swift methods have been exposed appropriately on Bugsnag only.

Implemented as simple dictionary operations with existence checks if appropriate.

Changeset

Bugsnag and BugsnagMetadata classes andd associated tests.

Tests

Unit tests were deemed appropriate. No CI tests were added.

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg force-pushed the robinmacharg/add-bugsnag.clearMetadata() branch from feacc5b to a4df655 Compare February 12, 2020 16:14
@robinmacharg robinmacharg marked this pull request as ready for review February 12, 2020 17:21
@fractalwrench fractalwrench removed their request for review February 17, 2020 14:14
* Use consistent English camel-casing
* Use clearMetadata to remove a section or individual value
@kattrali kattrali force-pushed the robinmacharg/add-bugsnag.clearMetadata() branch from fe8616f to 43dae25 Compare February 24, 2020 16:14
@kattrali kattrali merged commit 1652b85 into spec-compliance Feb 25, 2020
@kattrali kattrali deleted the robinmacharg/add-bugsnag.clearMetadata() branch February 25, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants