Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename BugsnagCrashReport to BugsnagEvent #449

Merged

Conversation

robinmacharg
Copy link
Contributor

@robinmacharg robinmacharg commented Jan 24, 2020

Goal

Rename the BugsnagCrashReport class to BugsnagEvent as a more accurate description of purpose and for greater consistency across Notifier platforms.

Design

Simple class rename.

Changeset

All mentions of BugsnagCrashReport changed to BugsnagEvent.

Tests

Tests were included in the rename, tests run manually and passed.

Review

Outstanding Questions

KSCrashReport mentions have been left as-is to reflect the origin of the BSG naming.

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg marked this pull request as ready for review January 24, 2020 15:34
@robinmacharg robinmacharg requested a review from kattrali January 24, 2020 15:34
@robinmacharg robinmacharg merged commit 00b7a09 into spec-compliance Jan 27, 2020
@twometresteve twometresteve deleted the robinmacharg/rename-crashreport-to-event branch June 8, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants