Lay out structure for property/method renames for v6.0 #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks like a good way to track changes in an upgrade guide.
My understanding is that we don't need to introduce backward compatibility by deprecating properties, as we're not planning on releasing these changes until the React Native project is complete. As a general comment we could therefore skip adding the deprecation notices when we're going to remove them very shortly afterwards - we can discuss internally whether that is the right approach for Cocoa.
There are a few discrepancies with the spec that I've commented on inline.
kattrali
force-pushed
the
kattrali/rename-config-consistency
branch
2 times, most recently
from
8738bf8 to
c3046ad
Compare
tomlongridge
requested changes
Dec 5, 2019
* Raises the default capacity to 25 * Prevents adding more than 100 per report
Co-Authored-By: Tom Longridge <[email protected]>
kattrali
force-pushed
the
kattrali/rename-config-consistency
branch
from
7470260 to
8a15acc
Compare
tomlongridge
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This changeset lays out an initial structure for the updates necessary to get the library ready for v6.0.0. The primary change in this major revision will be to rename some properties and methods to better align with other Bugsnag notifier libraries. These changes have been added in a backwards-compatible way to allow for incremental releases leading up to v6, when all deprecated properties will be removed.
Every change should be listed in the changelog and upgrade migration guide, and the new properties should replace the existing ones in the integration guide on docs.bugsnag.com.