-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(oom): Improve background app state detection #394
Conversation
084d943
to
c422ee1
Compare
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
==========================================
- Coverage 52.6% 52.36% -0.24%
==========================================
Files 65 65
Lines 7454 7497 +43
==========================================
+ Hits 3921 3926 +5
- Misses 3533 3571 +38
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments inline that'd be good to address/resolve, particularly the breaking change/mazerunner comments. Overall this seems like a good approach, although it'd be good to have a bit more background on how this could be tested for the purposes of code review.
9899e5f
to
de94c75
Compare
Didn't really affect anything since the raw data is appended to reports Moved private selector into private header
de94c75
to
4502ac2
Compare
Goal
Correctly determine foreground/active state when the app is launched via a background fetch or media playback event or extension, or is interrupted by Siri or a phone call. These cases should be regarded as in the background or inactive respectively.
Changeset
Tests