fix(codec): Parse numbers in arrays correctly #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove duplicate NULL check as stringFromCString already handles NULL
paulz
approved these changes
Jun 12, 2019
| // XCTAssertNil(error, @""); | ||
| // XCTAssertEqualObjects(result, original, @""); | ||
| //} | ||
| - (void)testSerializeDeserializeArrayMultipleEntries |
There was a problem hiding this comment.
Awesome job restoring commented out tests!
| @@ -1,17 +1,20 @@ | |||
| Feature: Handled Errors and Exceptions | |||
|
|
|||
| Scenario: Override errorClass and message from a notifyError() callback and discard lines from stack | |||
| Scenario: Override errorClass and message from a notifyError() callback, customize report | |||
There was a problem hiding this comment.
proposing adding the comment to the scenario about metadata, please adjust wording as necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix parsing logic for number values within arrays
Design
Previously, parsing numbers from JSON arrays exited prematurely if the "name" value was empty. However, name is always empty when parsing arrays, and is only used when parsing JSON objects.
So instead of exiting early to prevent parsing an invalid name, pass nil along as the name value.
Tests
Review