Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use depth in stacktrace length calc #363

Merged
merged 16 commits into from
Jun 12, 2019
Merged

Conversation

paulz
Copy link
Contributor

@paulz paulz commented Jun 11, 2019

Goal

Fixes #357

Design

Use top level dictionary to store depth

Changeset

Extracted report tests into a separate file

Tests

Unit test

Updated test expectations as per @kattrali comment:
#359 (comment)

Review

Outstanding Questions

  • Added a changelog entry? Not yet
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@paulz paulz requested review from snmaynard and kattrali June 11, 2019 00:04
@kattrali kattrali mentioned this pull request Jun 11, 2019
12 tasks
@kattrali
Copy link
Contributor

kattrali commented Jun 11, 2019

Per some in-person discussion, PR is ready pending:

  • Rebase against latest changes
  • Adding a functional test for changing depth via notify with block

@kattrali kattrali force-pushed the paul/fix-depth-fix-maze branch from 51de3fc to 0f73076 Compare June 12, 2019 10:07
Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small change in 0f73076 to test against the demangled Swift method name rather than the mangled one for both ease of readability and to reduce breakage later. Testing the mangled name failed for me locally because it was different by a single letter.

Looks good, next time let's get the changeset smaller by splitting up the tangentially related changes into separate PRs (renaming files, etc)

@kattrali kattrali changed the title Paul/fix depth fix maze fix: Use depth in stacktrace length calc Jun 12, 2019
@kattrali kattrali merged commit 94d262b into master Jun 12, 2019
@kattrali kattrali deleted the paul/fix-depth-fix-maze branch June 12, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjusting report depth for handled errors has no effect
2 participants