Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BSGConnectivity hostName #332

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

Jekiwijaya
Copy link
Contributor

@Jekiwijaya Jekiwijaya commented Mar 11, 2019

Goal

Fixing https://notify.bugsnag.com is being unresolved, since it's include the protocol, the accepted one is only hostname.
Group

https://developer.apple.com/documentation/systemconfiguration/1514904-scnetworkreachabilitycreatewithn

nodename
The node name of the desired host. This name is the same as that passed to the gethostbyname or getaddrinfo functions. The value of this parameter is copied into the new object.

Changeset

Changes

- NSString *hostName = [url absoluteString];
+ NSString *hostName = [url host];

Tests

It should be resolved
Group2

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@kattrali
Copy link
Contributor

Thank you, @Jekiwijaya!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants