Add stopSession() and resumeSession() to Bugsnag #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to stop and resume sessions. This prevents the handled/unhandled error count from affecting the stability score when a session is in the stopped state as they will not be serialised into error payloads. This can be useful when manually tracking sessions to avoid crashes in background services from affecting the score.
fractalwrench
force-pushed
the
stop-sessions
branch
from
0d8aa68 to
99fa60d
Compare
kattrali
reviewed
Feb 21, 2019
There was a problem hiding this comment.
Added a few things inline. As a more general comment which isn't limited to a specific line, there is a lot of switching between using the property and ivar accessors for SessionTracker.currentSession, which I think is intended to use or bypass the special behavior in -[SessionTracker currentSession] override implementation. This makes the implementation somewhat unclear and could be extracted into a function (e.g. [self runningSession]) and/or more heavily commented to explain what is being used and why.
test: add mazerunner scenarios for verifying stopSession and resumeSe…
fractalwrench
force-pushed
the
stop-sessions
branch
from
3e6162a to
dab4b07
Compare
|
Thanks for the feedback @kattrali - I've addressed the inline comments and have updated the |
kattrali
reviewed
Feb 26, 2019
kattrali
approved these changes
Feb 26, 2019
…on when incrementing handled er
This was referenced Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds the ability to stop and resume sessions. This prevents the handled/unhandled error count from incrementing when a session is in the stopped state, which may be desirable if a user manually tracks sessions and does not care about crashes that occur in the background.
Changeset
Added the public interface for stopping/resuming a session, along with the initial implementation and unit test coverage.
NOTE: mazerunner scenarios and documentation will be added in separate PRs.