Fixes Typo In Enumeration

[kleinlieu]

Goal

Found a typo in the spelling of one of the enums. I imagine this has downstream effects if anyone was using BSG_KSCDeleteOnSucess that would be guarded by a minor version upgrade since this will not be patch version compatible. Any suggestions appreciated.

Changeset

Changed

• Fixes typo in the spelling of BSG_KSCDeleteOnSucess to BSG_KSCDeleteOnSuccess

Tests

Discussion

Alternative Approaches

Outstanding Questions

Linked issues

Review

For the submitter, initial self-review:

• Commented on code changes inline explain the reasoning behind the approach
• Reviewed the test cases added for completeness and possible points for discussion
• A changelog entry was added for the goal of this pull request
• Check the scope of the changeset - is everything in the diff required for the pull request?
• This pull request is ready for:
  • Initial review of the intended approach, not yet feature complete
  • Structural review of the classes, functions, and properties modified
  • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

• Consistency across platforms for structures or concepts added or modified
• Consistency between the changeset and the goal stated above
• Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
• Usage friction - is the proposed change in usage cumbersome or complicated?
• Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
• Concurrency concerns - if components are accessed asynchronously, what issues will arise
• Thoroughness of added tests and any missing edge cases
• Idiomatic use of the language

[snmaynard]

We'll have to keep this PR waiting until we want to do a major release, as it is a breaking change - but it looks good, thanks for the contribution!

[mattdyoung]

Released in v6.0.0.

Note: There are a number of breaking changes in v6.0.0 as part of an effort to improve the interface and make it more consistent across our error reporting libraries, so please refer to the upgrade guide:
https://github.com/bugsnag/bugsnag-cocoa/blob/master/UPGRADING.md