fix: Adds fallback dictionary when serialising device info. #279
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // | ||
| // BugsnagKSCrashSysInfoParserTestTest.m | ||
| // Tests | ||
| // | ||
| // Created by Jamie Lynch on 15/05/2018. | ||
| // Copyright © 2018 Bugsnag. All rights reserved. | ||
| // | ||
|
|
||
| #import <XCTest/XCTest.h> | ||
|
|
||
| #import "BugsnagKSCrashSysInfoParser.h" | ||
|
|
||
| @interface BugsnagKSCrashSysInfoParserTest : XCTestCase | ||
| @end | ||
|
|
||
| @implementation BugsnagKSCrashSysInfoParserTest | ||
|
|
||
| - (void)testEmptyDictSerialisation { | ||
| // ensures that an empty dictionary parameter returns a fallback dictionary populated with at least some information | ||
| NSDictionary *device = BSGParseDevice(@{}); | ||
| XCTAssertNotNil(device); | ||
| XCTAssertNotNil(device[@"locale"]); | ||
| XCTAssertNotNil(device[@"freeDisk"]); | ||
| XCTAssertNotNil(device[@"simulator"]); | ||
| } | ||
|
|
||
| @end | ||
|
There was a problem hiding this comment. What happens if the report argument is nil? There was a problem hiding this comment. I've tested this out and a dictionary is returned with the same contents as if an empty dictionary had been passed in. Adding this as a test would currently fail the suite with an error, presumably due to the fact we've enabled strict build settings and this method parameter is enabled as NonNull. Do you feel we need to change anything so that this can be unit tested? There was a problem hiding this comment. Is it possible to loosen the restrictions on just the test files? It seems like it might be useful to have a test like that There was a problem hiding this comment. Do we need a test for a valid dictionary that contains the expected key? There was a problem hiding this comment. This is tested elsewhere I believe |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to do something like this? I'm not sure how
initWithDictionaryhandles nilThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initWithDictionary:requires a Nonnull parameter, whereasaddEntriesFromDictionary:handles a nil param.