Make error reports more customizable #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate notify:withData: and notify:withData:atSeverity:
Errors have a default severity of warning and automatically attach the error description, failure reason (if any), domain, and code as metadata
This reduces reuse of the metaData dictionary, which may be overridden itself. Makes tests pass
These callbacks are invoked before the reports are sent, rather than at crash time, like other Bugsnag libraries. Changing the name better reflects this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset modifies the previously-internal class
BugsnagCrashReportto be modifiable before sending reports to Bugsnag.Changes
BugsnagCrashReportand move report data into writable propertiesnotify:block:selector for customizing a crash report, deprecatingnotify:metaData:andnotify:metaData:severity:notifyError:andnotifyError:block:selectors for notifying about anNSErrorinstanceFixes #109
Fixes #103