Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-6307] Add macCatalystiOSVersion #1066

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Apr 9, 2021

Goal

Include information about the "simulated" iOS version when running Mac Catalyst apps or iOS apps running on Macs with Apple silicon.

Changeset

The iOSSupportVersion value from SystemVersion.plist is now sent as metaData.device.macCatalystiOSVersion

This appears in the device tab on the dashboard.

Screenshot 2021-04-07 at 16 02 19

Testing

Tested manually. We don't currently have tests or CI for Mac Catalyst or iOS apps on Macs with Apple silicon.

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,119,408 bytes

Generated by 🚫 Danger

@nickdowell nickdowell marked this pull request as ready for review April 9, 2021 10:06
@nickdowell nickdowell requested review from kattrali and kstenerud April 9, 2021 10:06
@nickdowell nickdowell merged commit ad3f1a3 into next Apr 9, 2021
@nickdowell nickdowell deleted the nickdowell/mac-catalyst-ios-version branch April 9, 2021 14:34
@nickdowell nickdowell mentioned this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants