[PLAT-6298] Improve accuracy of KSCrashReport timestamp #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
changed the title
nickdowell
force-pushed
the
nickdowell/crash-report-timestamp-accuracy
branch
from
73f2df4 to
8e165d3
Compare
This comment has been minimized.
This comment has been minimized.
nickdowell
force-pushed
the
nickdowell/crash-report-timestamp-accuracy
branch
from
8e165d3 to
04e0913
Compare
kattrali
approved these changes
Apr 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
KSCrashReport timestamps were accurate only to the nearest second.
This mean that some breadcrumbs could appear to occur after the error, e.g.
Changeset
Add a new
BSG_KSCrashField_Timestamp_Millisfield to KSCrashReports containing a millisecond-accurate timestamp.Based on the
gettimeofday()API which although not documented to be async-signal safe, is used bytimes()which is...Testing
Was able to reliably detect the issue in E2E tests. Verified that they now pass.