Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-6265] Support Mac Catalyst build #1056

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

nickdowell
Copy link
Contributor

Goal

Addresses #775

Changeset

Removes the SUPPORTS_MACCATALYST = NO build setting from the main Xcode project (this was not applied to Cocoapods and SwiftPM based builds)

Set up the example projects to allow testing with Mac Catalyst.

Testing

Tested locally.

@nickdowell nickdowell requested a review from kattrali March 30, 2021 16:01
@github-actions
Copy link

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,102,512 bytes

Generated by 🚫 Danger

@@ -5,6 +5,9 @@ Changelog

### Bug fixes

* Enable `SUPPORTS_MACCATALYST` in main Xcode project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this affects anyone vendoring bugsnag, and maybe Carthage builds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes; this affects anyone vendoring or using Carthage

@nickdowell nickdowell merged commit 42b8f4f into next Mar 31, 2021
@nickdowell nickdowell deleted the nickdowell/support-mac-catalyst-build branch March 31, 2021 09:04
@nickdowell nickdowell mentioned this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants