Replace sprintf in JSON encoder #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
6161-sprintf-replacement
branch
2 times, most recently
from
bd6c8bf to
f422b59
Compare
|
What effect does this have on the generated output? (if any) There does not appear to be much test coverage of the floating point output - is it worth adding some test cases for the various possible inputs? |
|
I'm still working on the tests. This was supposed to be a draft. Github is annoying in that way because any change to the PR details you make such as changing the base branch will automatically reset the PR type to "release". |
kstenerud
force-pushed
the
6161-sprintf-replacement
branch
4 times, most recently
from
282fc14 to
767924c
Compare
kstenerud
force-pushed
the
6161-sprintf-replacement
branch
from
767924c to
8af36fc
Compare
nickdowell
approved these changes
Mar 16, 2021
kattrali
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
sprintf can call malloc, which can cause lockups in a crash scenario. Replace the sprintf calls in the JSON encoder with async-safe code. The new code is a simplified algorithm that always outputs in exponential form when the exponent is not 0. The result is the same effective value as before when ingested by a machine, but it may look a little strange to a human.
Testing