[PLAT-6136] Fix missing / invalid device info when UIKit is not available #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
changed the title
nickdowell
force-pushed
the
nickdowell/fix-missing-device-info
branch
from
71cc83d to
b4e2979
Compare
kattrali
approved these changes
Mar 5, 2021
Merged
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes missing
osNameandosVersiondevice fields for errors reported from app extensions that do not link against UIKit.Also stops invalid
batteryLevelandchargingvalues being sent.Changeset
BSG_KSSystemInfonow readsNSOperatingSystemVersion(that was used on macOS) on iOS and tvOS.Hard-coded strings are now used for each OS name.
Testing
E2E tests have coverage of osName.
Manually tested with an app extension.
Manually verified that osVersion matches
-[UIDevice systemVersion]on iOS 14.5 beta.