Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-6132] Fix incorrect freeMemory for handled errors #1021

Merged
merged 6 commits into from
Mar 8, 2021

Conversation

nickdowell
Copy link
Contributor

Goal

Fixes a bug where handled errors (those reported via notify()) included an incorrect value for freeMemory

Changeset

The root cause was -[BSG_KSSystemInfo systemInfo] not including bsg_ksmachfreeMemory() and BugsnagDeviceWithState incorrectly falling back to the "usable" value instead.

Testing

Added E2E and unit test cases that replicate the problem, and verified they pass after the fix.

Manually verified that handled errors now contain freeMemory < totalMemory

@nickdowell nickdowell requested review from kstenerud and kattrali March 4, 2021 11:11
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size increased by 8 bytes from 1,084,888 to 1,084,896

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants