[PLAT-6075] Parse Swift 5.4 fatal error messages #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kattrali
approved these changes
Feb 23, 2021
| @"^(assertion failed|fatal error|precondition failed): ((.+): )?file .+, line \\d+\n$", | ||
| // From Swift 4.1: https://github.com/apple/swift/commit/d03a575279cf5c523779ef68f8d7903f09ba901e | ||
| @"^(Assertion failed|Fatal error|Precondition failed): ((.+): )?file .+, line \\d+\n$", | ||
| // From Swift 5.4: https://github.com/apple/swift/commit/1a051719e3b1b7c37a856684dd037d482fef8e59 |
There was a problem hiding this comment.
This update presents this information in a format matching the diagnostic conventions used by the compiler, which can be a slight productivity boost.
hahaha, well it does something nicer in vim at least, but that's an interesting reason to change a programming language 🙃
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
In Swift 5.4 (shipping with iOS 14.5) the format of Swift fatal error messages is changing: swiftlang/swift@1a05171
This PR updates the notifier's parsing code added in #948 to respond to this change.
Changeset
Added new regular expression patterns to cope with the change between versions.
Testing