Fix index into previous signal handlers table #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigNum is the signal itself, not an index into the previous signal handlers list. Get the actual index and use that instead.
nickdowell
reviewed
Feb 15, 2021
Bugsnag/KSCrash/Source/KSCrash/Recording/Sentry/BSG_KSCrashSentry_Signal.c
Show resolved
Hide resolved
nickdowell
approved these changes
Feb 15, 2021
This was referenced Feb 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal & design
A previous PR incorrectly used
sigNumas an index into thebsg_g_previousSignalHandlerstable. This PR derives the correct index.Changeset
Added
get_previous_sigaction(), which gets the correct index.Testing
Testing must be done manually. Before this fix, the "Mach exception" button in the example app will cause the app to freeze after recording the event. With this fix in place, it will correctly terminate the app after recording the event.
Tested on real devices running iOS 12.5.1 and 13.