Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support end user 'onCrash' handling #34

Closed
mlake opened this issue Dec 26, 2014 · 3 comments
Closed

Support end user 'onCrash' handling #34

mlake opened this issue Dec 26, 2014 · 3 comments

Comments

@mlake
Copy link

mlake commented Dec 26, 2014

Looks like KSCrash's onCrash handler is being used up for BugSnag to do its thing. We would like a way to add another handler for recording errors through our own custom tooling.

@ConradIrwin
Copy link
Contributor

We actually hook into its 'on boot after crash' hook. Would that work for
you?

Using onCrash is hard because it has to be async-safe.

Conrad

On Friday, December 26, 2014, Michael Lake [email protected] wrote:

Looks like KSCrash's onCrash handler is being used up for BugSnag to do
its thing. We would like a way to add another handler for recording errors
through our own custom tooling.


Reply to this email directly or view it on GitHub
#34.

@mlake
Copy link
Author

mlake commented Dec 27, 2014

Hmm...we'd like to record those crashes via Google Analytics as well as bugsnag....previously we would install our own master NSExceptionHandler which would call out to both, but it seems like we would miss out on other KScrash goodness if we did that.

Thoughts?? Michael

On Dec 27, 2014, at 12:48 PM, Conrad Irwin [email protected] wrote:

We actually hook into its 'on boot after crash' hook. Would that work for
you?

Using onCrash is hard because it has to be async-safe.

Conrad

On Friday, December 26, 2014, Michael Lake [email protected] wrote:

Looks like KSCrash's onCrash handler is being used up for BugSnag to do
its thing. We would like a way to add another handler for recording errors
through our own custom tooling.


Reply to this email directly or view it on GitHub
#34.


Reply to this email directly or view it on GitHub.

@snmaynard
Copy link
Contributor

Perhaps we could combine this with #17 to fix both issues at the same time? Some user code could run before sending a notification with the caveat that it is run out of the context of the crash (next boot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants