Merge pull request #789 from bugsnag/analyzer-fixes

[PLAT-4777] Fix some analyzer false positives.
bugsnag · Sep 3, 2020 · 8a0d267 · 8a0d267
2 parents 75ac232 + 43402a2
commit 8a0d267
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/Bugsnag/KSCrash/Source/KSCrash/Recording/Tools/BSG_KSMach.c b/Bugsnag/KSCrash/Source/KSCrash/Recording/Tools/BSG_KSMach.c
@@ -347,6 +347,8 @@ bool bsg_ksmachsuspendAllThreadsExcept(thread_t *exceptThreads,
                 // Don't treat this as a fatal error.
                 BSG_KSLOG_DEBUG("thread_suspend (%08x): %s", thread,
                                 mach_error_string(kr));
+                // Suppress dead store warning when log level > debug
+                (void)kr;
             }
         }
     }
@@ -386,6 +388,8 @@ bool bsg_ksmachresumeAllThreadsExcept(thread_t *exceptThreads,
                 // Don't treat this as a fatal error.
                 BSG_KSLOG_DEBUG("thread_resume (%08x): %s", thread,
                                  mach_error_string(kr));
+                // Suppress dead store warning when log level > debug
+                (void)kr;
             }
         }
     }

diff --git a/Bugsnag/KSCrash/Source/KSCrash/Recording/Tools/BSG_KSMachHeaders.m b/Bugsnag/KSCrash/Source/KSCrash/Recording/Tools/BSG_KSMachHeaders.m
@@ -192,7 +192,7 @@ bool bsg_mach_headers_populate_info(const struct mach_header *header, intptr_t s
 void bsg_mach_headers_add_image(const struct mach_header *header, intptr_t slide) {
 
     BSG_Mach_Header_Info *newImage = malloc(sizeof(BSG_Mach_Header_Info));
-    if (newImage != NULL && errno != ENOMEM) {
+    if (newImage != NULL) {
         if (bsg_mach_headers_populate_info(header, slide, newImage)) {
 
             bsg_mach_headers_cache_lock();

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,13 @@
 Changelog
 =========
 
+## TBD
+
+### Bug fixes
+
+* Quiet some Analyzer false positives
+  [#789](https://github.com/bugsnag/bugsnag-cocoa/pull/789)
+
 ## 6.1.3 (2020-08-17)
 
 ### Bug fixes