Update React Native tests #179
Open
+114
−8,788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
reviewed
Mar 4, 2025
features/react-native/ios.feature
Outdated
Comment on lines
34
to
43
| # --bundle=STRING The path to the bundled JavaScript file to upload | ||
| # --code-bundle-id=STRING A unique identifier for the JavaScript bundle | ||
| # --dev Indicates whether this is a debug or release build | ||
| # --source-map=STRING The path to the source map file to upload | ||
| # --version-name=STRING The version of the application | ||
| # --bundle-version=STRING The bundle version of this build of the application (Apple platforms only) | ||
| # --plist=STRING The path to a .plist file from which to obtain build information | ||
| # --scheme=STRING The name of the Xcode options.Ios.Scheme used to build the application | ||
| # --xcode-project=STRING The path to an Xcode project, workspace or containing directory from which to obtain build information | ||
| # --xcarchive-path=PATH The path to the .xcarchive to process if it has been exported |
There was a problem hiding this comment.
Looks like this has been erroneously copied in...
features/steps/steps.rb
Outdated
Comment on lines
246
to
258
| if ENV['RN_VERSION'].to_f == 0.70 | ||
| ENV['APP_MANIFEST_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/intermediates/merged_manifests/release/AndroidManifest.xml" | ||
| ENV['BUNDLE_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/assets/react/release/index.android.bundle" | ||
| ENV['SOURCE_MAP_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/sourcemaps/react/release/index.android.bundle.map" | ||
| elsif ENV['RN_VERSION'].to_f == 0.73 | ||
| ENV['APP_MANIFEST_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/intermediates/merged_manifests/release/AndroidManifest.xml" | ||
| ENV['BUNDLE_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/assets/createBundleReleaseJsAndAssets/index.android.bundle" | ||
| ENV['SOURCE_MAP_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/sourcemaps/react/release/index.android.bundle.map" | ||
| elsif ENV['RN_VERSION'].to_f == 0.75 | ||
| ENV['APP_MANIFEST_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/intermediates/merged_manifests/release/processReleaseManifest/AndroidManifest.xml" | ||
| ENV['BUNDLE_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/assets/createBundleReleaseJsAndAssets/index.android.bundle" | ||
| ENV['SOURCE_MAP_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/sourcemaps/react/release/index.android.bundle.map" | ||
| end |
There was a problem hiding this comment.
How about expressing it like this to make it clearer what the differences are? (It pushes the full feature path to the feature script and allows this to be just the differences between versions - so we can add new ones if the path changes again.)
Suggested change
| if ENV['RN_VERSION'].to_f == 0.70 | |
| ENV['APP_MANIFEST_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/intermediates/merged_manifests/release/AndroidManifest.xml" | |
| ENV['BUNDLE_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/assets/react/release/index.android.bundle" | |
| ENV['SOURCE_MAP_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/sourcemaps/react/release/index.android.bundle.map" | |
| elsif ENV['RN_VERSION'].to_f == 0.73 | |
| ENV['APP_MANIFEST_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/intermediates/merged_manifests/release/AndroidManifest.xml" | |
| ENV['BUNDLE_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/assets/createBundleReleaseJsAndAssets/index.android.bundle" | |
| ENV['SOURCE_MAP_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/sourcemaps/react/release/index.android.bundle.map" | |
| elsif ENV['RN_VERSION'].to_f == 0.75 | |
| ENV['APP_MANIFEST_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/intermediates/merged_manifests/release/processReleaseManifest/AndroidManifest.xml" | |
| ENV['BUNDLE_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/assets/createBundleReleaseJsAndAssets/index.android.bundle" | |
| ENV['SOURCE_MAP_PATH'] = "features/react-native/fixtures/generated/old-arch/#{ENV['RN_VERSION']}/android/app/build/generated/sourcemaps/react/release/index.android.bundle.map" | |
| end | |
| ENV['APP_MANIFEST_PATH'] = "android/app/build/intermediates/merged_manifests/release/processReleaseManifest/AndroidManifest.xml" | |
| ENV['BUNDLE_PATH'] = "android/app/build/generated/assets/createBundleReleaseJsAndAssets/index.android.bundle" | |
| ENV['SOURCE_MAP_PATH'] = "android/app/build/generated/sourcemaps/react/release/index.android.bundle.map" | |
| if ENV['RN_VERSION'].to_f < 0.75 | |
| ENV['APP_MANIFEST_PATH'] = "android/app/build/intermediates/merged_manifests/release/AndroidManifest.xml" | |
| elsif ENV['RN_VERSION'].to_f < 0.73 | |
| ENV['BUNDLE_PATH'] = "android/app/build/generated/assets/react/release/index.android.bundle" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Update the React Native iOS and Android tests to cover the escape hatches
Remove the old React Native fixture files.
Testing
Covered by CI