Parse FeatureFlags when OnSendCallbacks are configured #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-7194/onsend-feature-flags
branch
from
e527ad4 to
4299611
Compare
…backs are configured
lemnik
force-pushed
the
PLAT-7194/onsend-feature-flags
branch
from
4299611 to
3f8b852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix a bug where configuring an
OnSendCallbackwould potentially cause feature flags to be dropped from reports. This was caused byBugsnagEventMappernot parsing the feature flags list back into the in-memory model, causing them to be dropped from anyEventthat was stored on disk (although only if anOnSendCallbackwas configured).Testing
Additional unit tests, and new Mazerunner tests to cover this scenario.