Don't attempt to share the bsg_jni_cache between threads
#1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-7876/threadsafe-jni-cache
branch
from
581c764 to
fb806f1
Compare
kstenerud
approved these changes
Jan 21, 2022
| if (!bsg_jni_cache_refresh(env)) { | ||
| bsg_jni_cache jni_cache; | ||
|
|
||
| if (!bsg_jni_cache_refresh(env, &jni_cache)) { |
There was a problem hiding this comment.
This name doesn't really describe it properly anymore. It's not refreshing the cache, but rather filling it completely. Can we change it?
lemnik
force-pushed
the
PLAT-7876/threadsafe-jni-cache
branch
2 times, most recently
from
a581ac3 to
9f49860
Compare
lemnik
force-pushed
the
PLAT-7876/threadsafe-jni-cache
branch
from
9f49860 to
64795b4
Compare
Android notifier sizes
Generated by 🚫 Danger |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix
SIGABRTcrashes caused by multiple threads reading and writing to the globalbsg_jni_cachesimultaneously.Design
Replace the global JNI cache with a single cache for each JNI function call. A stack-allocated cache is populated on-entry to the NDK layer and a pointer to the cache is then passed into each function that requires it. This avoids any allocation errors, and ensures that JNI objects don't accidentally cross thread-boundaries.
Testing
Manual testing with an app known to cause this issue. Due to the race-condition nature of this crash, no additional automated tests can be added at this time.