Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to build with Kotlin 1.4 #1565

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

fractalwrench
Copy link
Contributor

Goal

Updates the project to build with Kotlin 1.4, while targeting an API version of 1.3.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench force-pushed the PLAT-4855/update-kotlin-version branch from a791182 to e55cb13 Compare December 21, 2021 11:17
@fractalwrench fractalwrench requested a review from lemnik December 21, 2021 11:18
@fractalwrench fractalwrench force-pushed the PLAT-4855/update-kotlin-version branch from e55cb13 to b2b44b9 Compare December 21, 2021 11:25
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Dec 21, 2021

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1409.5 1167.26
arm64_v8a 536.97 299.4
armeabi -492.59 -21.55
armeabi_v7a 508.31 270.74
x86 577.91 340.35
x86_64 561.54 323.97

Generated by 🚫 Danger

@fractalwrench fractalwrench force-pushed the PLAT-7340/explicit-kotlin-versions branch from a0bb1e8 to 76e9f23 Compare December 23, 2021 09:48
@fractalwrench fractalwrench force-pushed the PLAT-4855/update-kotlin-version branch from b2b44b9 to dbd54ab Compare December 23, 2021 09:49
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the PLAT-7340/explicit-kotlin-versions branch from 76e9f23 to 4e35d49 Compare January 6, 2022 12:02
@fractalwrench fractalwrench force-pushed the PLAT-4855/update-kotlin-version branch from dbd54ab to 7c85ed6 Compare January 6, 2022 12:02
@fractalwrench fractalwrench force-pushed the PLAT-7340/explicit-kotlin-versions branch from 4e35d49 to 02c26f4 Compare January 6, 2022 15:03
@fractalwrench fractalwrench force-pushed the PLAT-4855/update-kotlin-version branch from 7c85ed6 to 57a0ef7 Compare January 6, 2022 15:03
Base automatically changed from PLAT-7340/explicit-kotlin-versions to next January 6, 2022 16:28
@fractalwrench fractalwrench merged commit 116a2a9 into next Jan 7, 2022
@fractalwrench fractalwrench deleted the PLAT-4855/update-kotlin-version branch January 7, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants