Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly define Kotlin api/language versions #1564

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Dec 20, 2021

Goal

Explicitly defines that bugsnag-android uses Kotlin 1.3 to build, and should target API compatibility with 1.3. This is achieved by setting the compiler options.

Future updates may increase the api/language version used - for now this changeset just defines what is already in use.

Testing

Relied on existing test coverage. I also logged out the properties of kotlinOptions to confirm that the apiVersion and languageVersion were set on each task, whereas they were not before.

@fractalwrench fractalwrench force-pushed the PLAT-7340/explicit-kotlin-versions branch from 35b7cbf to 93029a5 Compare December 20, 2021 15:56
@fractalwrench fractalwrench requested a review from lemnik December 20, 2021 15:56
@fractalwrench fractalwrench force-pushed the PLAT-7340/explicit-kotlin-versions branch from 93029a5 to a0bb1e8 Compare December 20, 2021 16:46
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Dec 21, 2021

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1353.03 1167.83
arm64_v8a 483.72 299.4
armeabi -492.59 -21.55
armeabi_v7a 455.06 270.74
x86 520.57 340.35
x86_64 508.29 323.97

Generated by 🚫 Danger

@fractalwrench fractalwrench force-pushed the PLAT-7340/explicit-kotlin-versions branch from a0bb1e8 to 76e9f23 Compare December 23, 2021 09:48
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the PLAT-7340/explicit-kotlin-versions branch from 76e9f23 to 4e35d49 Compare January 6, 2022 12:02
@fractalwrench fractalwrench force-pushed the PLAT-7340/explicit-kotlin-versions branch from 4e35d49 to 02c26f4 Compare January 6, 2022 15:03
@fractalwrench fractalwrench merged commit 05fec5a into next Jan 6, 2022
@fractalwrench fractalwrench deleted the PLAT-7340/explicit-kotlin-versions branch January 6, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants