Skip to content

Conversation

aidanstansfield
Copy link
Contributor

@aidanstansfield aidanstansfield commented Nov 24, 2020

Issue: Resolves #308

No alteration of VRT items, just altering remediation advice.

Remediation Advice Mapping:

Changed advice from Cache-Control: no-cache to Cache-Control: no-store.

Checklist:

  • I have added entries to CHANGELOG.md and marked it Added/Changed/Removed
  • I have made corresponding changes to the documentation (if needed)

@adamrdavid
Copy link
Contributor

might still be nice to add a section to changed in CHANGELOG.

@aidanstansfield
Copy link
Contributor Author

Added section to changelog

Copy link
Contributor

@plr0man plr0man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is looking good!
The changelog update would be better if it included the entry name. For example here is a past changelog entry for something similar:
"broken_authentication_and_session_management.failure_to_invalidate_session.on_password_change updated remediation advice"

@adamrdavid adamrdavid merged commit 4e811e7 into master Feb 12, 2021
@adamrdavid adamrdavid deleted the update-cache-control-advice branch February 12, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update remediation advice for cache control for a [non-]sensitive page

3 participants