gogo support #66
gogo support #66
Conversation
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
|
Partially addresses #52 |
|
@rodaine I want to hear your thoughts how best to structure this. I can fix the build once we agree how to get this started. |
templates/go/duration.go
Outdated
| if err != nil { return {{ errCause . "err" "value is not a valid duration" }} } | ||
| {{ end }} | ||
| {{ end }} | ||
| {{ else }} |
There was a problem hiding this comment.
Instead of these big conditionals, how about we move the shared templates into something like goshared and have separate templates for where the two targets diverge? So everything but duration, time, and file (or perhaps just a preamble) are shared. Does that make sense?
tests/kitchensink/gogo/any.pb.go
Outdated
| @@ -0,0 +1,490 @@ | |||
| // Code generated by protoc-gen-gogo. | |||
There was a problem hiding this comment.
Please exclude the test gen'd code
tests/kitchensink/duration.proto
Outdated
| google.protobuf.Duration gogo1 = 17 [(validate.rules).duration.lt = {seconds: 5}, (gogoproto.stdduration) = true]; | ||
| google.protobuf.Duration gogo2 = 18 [(validate.rules).duration.lt = {seconds: 5}, (gogoproto.nullable) = false]; | ||
| google.protobuf.Duration gogo3 = 19 [(validate.rules).duration.lt = {seconds: 5}, (gogoproto.stdduration) = true, (gogoproto.nullable) = false]; | ||
| google.protobuf.Duration gogo4 = 20 [(validate.rules).duration.required = true, (gogoproto.nullable) = false]; |
There was a problem hiding this comment.
Can these have more descriptive names? Makes it easier to debug when looking at the generator output.
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
|
Thanks @rodaine. Can you help me bring in gogo protoc plugin into the CI docker image? |
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
|
Build fixed! |
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
|
PTAL, added docs and separate templates into go/gogo as requested. |
templates/gogo/duration.go
Outdated
|
|
||
| {{ template "durationcmp" . }} | ||
| } | ||
| {{ end }} |
There was a problem hiding this comment.
The nesting here is difficult to follow. We run gofmt against generated code, so you should just structure the template for readability and let the formatter fix it in the final output.
There was a problem hiding this comment.
Thanks, responded.
Signed-off-by: Kuat Yessenov <[email protected]>
This is a working prototype for implementing constraints for gogo-generated protobufs.
This is sufficient for handling envoyproxy/data-plane-api:
Signed-off-by: Kuat Yessenov [email protected]