Add support for external test harness #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akonradi
suggested changes
Jun 8, 2020
thesamet
force-pushed
the
master
branch
3 times, most recently
from
b26d7c9 to
5972dad
Compare
akonradi
suggested changes
Jun 8, 2020
akonradi
previously approved these changes
Jun 8, 2020
|
For reference, this is how this is used right now in scalapb-validate's ScalaHarness. We inverted the control, so the Scala code calls the harness and keeps a single JVM for the entire test, which make it significantly faster (compared to the approach of launching a new JVM for each case). Though we still have over 100 test errors to fix :) |
|
That makes sense. One of the reasons the test is so slow is that the Java harness takes forever to run since it also starts a new JVM every time. @thesamet can you merge master? |
|
Sure, I rebased and squashed this into a single commit. |
Signed-off-by: Nadav Samet <[email protected]>
akonradi
approved these changes
Jun 9, 2020
Merged
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am building PGV support for ScalaPB. As ScalaPB offers many ways for users to customize the generated code and the generator is written in Scala, it would be impractical to add ScalaPB support directly in here.
We have started to put some effort in https://github.com/scalapb/scalapb-validate and it would be nice to be able to run PGV's test harness against scalapb-validate. To accomplish that, I would like to be able to specify an external program to the harness.
See #322