Update tests for @bufbuild/protoplugin #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Into one file for import() and one for file(). Extend coverage.
Extend coverage: - Check that no duplicate files are generated - Check that expected generator functions are called - Check that transpile is called when expected
…m-options.test.ts
smaye81
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all tests for the plugin framework to use the internal
upstream-protobufpackage to generate descriptors and code generator requests on the fly. The first tests using this approach were added in #649 - with this PR, all tests are using it. This unblocks tests covering option retention, and generally gives us the flexibility in test setups we need to support editions.