Skip to content

Fix unused MethodInfo properties in createRegistryFromDescriptors #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timostamm merged 1 commit into from
Mar 13, 2023
Merged

Fix unused MethodInfo properties in createRegistryFromDescriptors #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/protobuf/src/create-registry-from-desc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,16 +189,15 @@ export function createRegistryFromDescriptors(
method.output.typeName
}" for ${method.toString()} not found`
);
const m = {
methods[localName(method)] = {
name: method.name,
localName: localName(method),
I,
O,
kind: method.methodKind,
idempotency: method.idempotency,
options: {},
// We do not surface options at this time
// options: {},
};
methods[m.localName] = m;
}
return (services[typeName] = {
typeName: desc.typeName,
Expand Down
2 changes: 0 additions & 2 deletions packages/protobuf/src/proto-base64.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ export const protoBase64 = {
dec(base64Str: string): Uint8Array {
// estimate byte size, not accounting for inner padding and whitespace
let es = (base64Str.length * 3) / 4;
// if (es % 3 !== 0)
// throw new Error("invalid base64 string");
if (base64Str[base64Str.length - 2] == "=") es -= 2;
else if (base64Str[base64Str.length - 1] == "=") es -= 1;

Expand Down
2 changes: 0 additions & 2 deletions packages/protobuf/src/service-type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ export interface ServiceType {
* call. All methods provide the following properties:
*
* - "name": The original name of the protobuf rpc.
* - "localName": A variation of the name that follows the lowerCamelCase
* naming convention in ECMAScript.
* - "I": The input message type.
* - "O": The output message type.
* - "kind": The method type.
Expand Down