Allow optional fields to be explicitly set to undefined#374
Closed
haines wants to merge 1 commit intobufbuild:mainfrom
Closed
Allow optional fields to be explicitly set to undefined#374haines wants to merge 1 commit intobufbuild:mainfrom
undefined#374haines wants to merge 1 commit intobufbuild:mainfrom
Conversation
Contributor
|
Hey @haines thank you for the PR. Appreciate you being patient. Our approach has been that we support the default compiler settings for a particular version of TypeScript. And since That being said, if this becomes a default setting, we would certainly support it at that time. Thanks again for the consideration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows fields to be set to
undefinedexplicitly even when the TypeScript compiler optionexactOptionalPropertyTypesis enabled.Currently optional message fields are typed as
field?: Typebut with
exactOptionalPropertyTypesthis means you can't set them toundefined; you have to omit them. This is a bit inconvenient if you're trying to pass through a value from a variable.This PR changes the optional fields to be typed as
which removes the restriction.