Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rust editions #91

Merged
merged 4 commits into from
Dec 4, 2018
Merged

Conversation

Phlosioneer
Copy link
Contributor

Closes #90

Accidentally left in print statements from debugging.
@Phlosioneer
Copy link
Contributor Author

The random error in the one travis test seems to be a bug in cargo_metadata. I submitted a fix for it.

@Phlosioneer
Copy link
Contributor Author

The error in cargo_metadata has been fixed, and was pushed as 0.6.3. Can the tests be rerun?
Ping @budziq

Copy link
Owner

@budziq budziq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Phlosioneer for working on it, awesome work!

Only two suggestions. Would you be able to look into these?

src/skeptic/lib.rs Outdated Show resolved Hide resolved
src/skeptic/lib.rs Outdated Show resolved Hide resolved
@budziq budziq merged commit 48a8064 into budziq:master Dec 4, 2018
@budziq
Copy link
Owner

budziq commented Dec 4, 2018

Thanks a lot @Phlosioneer! Already published as 0.13.4

So cool to see ggez starting to use skeptic ❤️

h-michael added a commit to h-michael/graphql-client that referenced this pull request Mar 23, 2019
h-michael added a commit to h-michael/graphql-client that referenced this pull request Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants